Repository navigation
refactor(ui5-responsive-popover): API enhancements - #3363
Merged
Merged
Conversation
ilhan007
changed the title
kskondov
force-pushed
the
responsive-popover-api-enhancements
branch
from
May 31, 2021 08:31
7b3f565 to
3599878
Compare
Contributor
|
The commit message still says "i5-responsive-popover" |
This was referenced Jun 7, 2021
Closed
Part of #3107 BREAKING_CHANGE: open method renamed to openBy
georgimkv
force-pushed
the
responsive-popover-api-enhancements
branch
from
June 7, 2021 09:39
32fa701 to
5cfd6f4
Compare
dimovpetar
approved these changes
Jun 8, 2021
dimovpetar
requested changes
Jun 8, 2021
dimovpetar
left a comment
dimovpetar
left a comment
Member
There was a problem hiding this comment.
Replace simpleRP.open(btnSimpleRP) with simpleRP.openBy(btnSimpleRP) in ResponsivePopover.html
dimovpetar
approved these changes
Jun 21, 2021
ilhan007
approved these changes
Jun 21, 2021
1 of 4 tasks
kskondov
added a commit
that referenced
this pull request
Jul 5, 2021
Part of #3107 BREAKING_CHANGE: The ResponsivePopover `open` method has been renamed to `openBy`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3107
BREAKING_CHANGE: open method renamed to openBy